-
Notifications
You must be signed in to change notification settings - Fork 197
Fix outdated mini_file_server.dart #61
base: master
Are you sure you want to change the base?
Conversation
Issue - dart-lang/site-www#2646 - Propose to fix mini server example continuous loop on the connection.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propose to fix mini server example continuous loop on the connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix blocking variables with a standard "string" message
To resolve the dart type issues within the print statement feedback on the server response. Expected response `Listening on 127.0.0.1:4044` on call instead of `Listening on localhost:4044`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwalrath If you would be kind to see my revisions regarding the type difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what we need to do is just copy https://github.com/dart-lang/site-www/blob/master/examples/httpserver/bin/mini_file_server.dart to this repo. That'll get rid of some problems like the unnecessary import of dart:async.
(It's kind of terrible that we have the code in 2+ places. I believe that @RedBrogdon will make sure this duplication gets fixed, one way or another.)
I've edited single quotes for example file instead of double based on conversation. These can be merged.
Issue - dart-lang/site-www#2646 - Propose to fix mini server example continuous loop on the connection.